Disable weak event emitter in AttributedString for Apple Silicon Mac running iOS build app #48583
Conversation
…running iOS build app The weak event emitter in AttributedString attributes is causing a serialization error when typing into a TextInput in a iOS build app running on Apple Silicon Mac. ## Changelog [iOS][Fixed] - Workaround for a iOS build app running on Apple Silicon Mac(in Xcode Destination: "Mac(Designed for iPad)") TextInput crash due to serialization attempt of WeakEventEmitter
|
Hi @iwater! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
iwater
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
CLA Signed
|
While this may fix the crash, it will likely break pointer input on (nested) Text elements. Can you verify this still works? |
|
This would fix #48544 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi Any update on if this will be merged? Or is a different solution needed? |
|
Sorry, there were a bunch of discussions internally. We can start landing this for now, but it is likely that we will rework that part at some point |
|
@cipolleschi merged this pull request in 0511e2e. |
|
This pull request was successfully merged by @iwater in 0511e2e When will my fix make it into a release? | How to file a pick request? |
|
This is not yet part of the |
|
@wottpal It is indeed not included yet. Please see the pick requests above your comment that are asking for this fix to be included in the next releases of You can also check the tags on the commit 0511e2e and you can see it is not tagged with any version yet and so it has not been included in any release. |
|
This pull request has been reverted by 9b06d0d. |
#48225 fixed the same problem on Mac Catalyst build, but this crash also happen on a iOS build app running on Apple Silicon Mac.
The weak event emitter in AttributedString attributes is causing a serialization error when typing into a TextInput in a iOS build app running on Apple Silicon Mac.
Changelog
[iOS][Fixed] - Workaround for a iOS build app running on Apple Silicon Mac(in Xcode Destination: "Mac(Designed for iPad)") TextInput crash due to serialization attempt of WeakEventEmitter
Summary:
Changelog:
Test Plan: